Re: [PATCH 03/11] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660

[David Heidelberg]

On 02/11/2026 10:58, Konrad Dybcio wrote:
> On 10/31/26 4:05 PM, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@xxxxxxx>
> >
> > The VBUS register block on the PMI8998 and PM660 PMIC shares the design
> > with the PM8150B one. Define corresponding compatible string, having the
> > qcom,pm8150b-vbus-reg as a fallback.
> >
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
>
> This is absolutely not true. They both have a similar CMD_OTG
> register at +0x40 which makes the driver seem like it's working
> for you, but otherwise the register layout diverges a lot.

In that case, since current skeleton and implemented features are common, I 
would add separate pmi8998/pm660 compatible to the driver, without functional 
changes AND without the compatible fallback to 8150b?

Looking into docs, do you consider it good enough?

David

> Konrad