Re: [PATCH v2 5/5] iio: chemical: sgp40: Implement turn_heater_off-command

[Joshua Crofts]

On Mon, 2 Nov 2026 11:56:02 +0200
Jaakko Koivisto <jmatko@xxxxxx> wrote:

...

> +static int sgp40_turn_heater_off(struct sgp40_data *data)
> +{
> +	int ret;
> +	struct i2c_client *client = data->client;
> +	struct sgp40_tg_measure turn_off = { .command = {0x36, 0x15} };

Reverse xmas tree.

> +
> +	guard(mutex)(&data->lock);
> +
> +	ret = i2c_master_send(client, (char *)&turn_off, sizeof(turn_off.command));
> +	if (ret < 0)
> +		return ret;
> +	if (ret != sizeof(turn_off.command))
> +		return dev_err_probe(data->dev, -EIO,
> +		       "i2c_master_send ret: %d, expected %zu", ret, sizeof(turn_off.command));

Again, this function isn't called from probe(), yet it uses
dev_err_probe().

-- 
Kind regards,
Joshua Crofts