Re: [PATCH v2 4/5] iio: chemical: sgp40: Implement execute_self_test-command
From: Joshua Crofts
Date: Mon Nov 02 2026 - 05:29:40 EST
On Mon, 2 Nov 2026 11:12:57 +0200
Jaakko Koivisto <jmatko@xxxxxx> wrote:
...
> static const struct iio_chan_spec sgp40_channels[] = {
> {
> .type = IIO_CONCENTRATION,
> @@ -209,6 +222,47 @@ static int sgp40_get_serial_number(struct sgp40_data *data, u64 *serial_number)
> return 0;
> }
>
> +static int sgp40_execute_self_test(struct sgp40_data *data)
> +{
> + int ret;
> + struct i2c_client *client = data->client;
> + struct sgp40_tg_measure run_test = { .command = {0x28, 0x0E} };
> + struct sgp40_self_test_result res;
Reverse xmas tree.
Otherwise LGTM.
--
Kind regards,
Joshua Crofts