Re: [PATCH v7 12/13] can: peak_usb: dump undecodable URBs once and rate limit decode errors

From: Stéphane Grosjean

Date: Mon Nov 02 2026 - 06:00:33 EST


On 01/11/2026 03:15, netdev-bot+sashiko@xxxxxxxxxx wrote:
[...]
> [Severity: Low]
> Can the decoder's error message and the dump of the same URB get split
> up by two separate net_ratelimit() decisions?
[...]
> Would making one rate-limit decision per URB, either
> in the core or passed down to the decoders, keep each message and its
> dump together?

Yes, they can be split during a burst. I'd rather not pass a rate
limit decision down to the decoders for this: each message already
says what is wrong with the URB, and the dump only completes it. In
v8, I'll drop the trailing colon of "got unsupported rec in usb msg",
which announced a dump that may no longer follow it, and say in the
commit message that both are rate limited separately.

Thanks!

Stéphane