Re: [PATCH net] ppp: remove SC_MUST_COMP

[Paolo Abeni]

On 10/31/26 02:28, Qingfang Deng wrote:
> On 10/31/2026 5:32 AM, netdev-bot+sashiko@xxxxxxxxxx wrote:
> > Would it work to keep the define, with a comment that the kernel ignores
> > it and that it aliases SC_DC_ERROR, while still dropping it from
> > SC_FLAG_BITS and SC_MASK and removing the checks?
>
> I found no trace of existing users (searched GitHub). Even _if_ there are any, _and_ SC_MUST_COMP does not alias SC_DC_ERROR, the logic is still flawed - received packets are silently dropped without noticing the userspace.
>
> If the goal is to prevent the removal from backports, I may split out the removal part into a net-next patch.

I'm sorry to disagree with Simon, but I think we should not
change uAPI unless strictly required.

I would just mark `SC_MUST_COMP` as obsoleted since <revision>.

/P