Re: [PATCH] ALSA: pcm: Fix source frame count calculation

From: Takashi Iwai

Date: Mon Nov 02 2026 - 10:59:01 EST


On Mon, 02 Nov 2026 15:47:36 +0100,
Sreeraj S Kurup wrote:
>
> You're right. I checked the callback implementation, and
> "snd_pcm_plugin_client_channels()" always returns the input
> frame count. All plugins created through "snd_pcm_plugin_build()"
> use this callback.
>
> So the condition "err != frames1" is not reached in the normal path.
> My patch is unnecessary. Sorry for the noise.

Well, the logic you described looks still correct, so it's better to
correct the code even if it's only hypothetical.

So I applied your patch now with a bit more explanation.


thanks,

Takashi