[PATCH 1/1] slimbus: use dmaengine_desc_set_callback()
From: Frank . Li
Date: Mon Nov 02 2026 - 13:07:48 EST
From: Frank Li <Frank.Li@xxxxxxx>
Replace open-coded assignments to callback and callback_param fields
of struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.
No functional change intended. Prepare make to struct
dma_async_tx_descriptor private to the DMA engine.
Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
---
drivers/slimbus/qcom-ngd-ctrl.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index eb983b6d1815f..539c8a6493969 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -595,8 +595,7 @@ static int qcom_slim_ngd_tx_msg_post(struct qcom_slim_ngd_ctrl *ctrl,
return -EINVAL;
}
- desc->desc->callback = qcom_slim_ngd_tx_msg_dma_cb;
- desc->desc->callback_param = desc;
+ dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_tx_msg_dma_cb, NULL, desc);
desc->desc->cookie = dmaengine_submit(desc->desc);
dma_async_issue_pending(ctrl->dma_tx_channel);
spin_unlock_irqrestore(&ctrl->tx_buf_lock, flags);
@@ -642,8 +641,7 @@ static void qcom_slim_ngd_rx_msgq_cb(void *args)
return;
}
- desc->desc->callback = qcom_slim_ngd_rx_msgq_cb;
- desc->desc->callback_param = desc;
+ dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_rx_msgq_cb, NULL, desc);
desc->desc->cookie = dmaengine_submit(desc->desc);
dma_async_issue_pending(ctrl->dma_rx_channel);
}
@@ -667,8 +665,7 @@ static int qcom_slim_ngd_post_rx_msgq(struct qcom_slim_ngd_ctrl *ctrl)
return -EINVAL;
}
- desc->desc->callback = qcom_slim_ngd_rx_msgq_cb;
- desc->desc->callback_param = desc;
+ dmaengine_desc_set_callback(desc->desc, qcom_slim_ngd_rx_msgq_cb, NULL, desc);
desc->desc->cookie = dmaengine_submit(desc->desc);
}
dma_async_issue_pending(ctrl->dma_rx_channel);
--
2.43.0