Re: [PATCH v2 8/9] media: qcom: camss: Switch on frame_sync_en for x1e/x2e

[Bryan O'Donoghue]

On 02/11/2026 14:32, Konrad Dybcio wrote:
> On 11/2/26 2:56 PM,bryan.odonoghue@xxxxxxxxxx wrote:
> > From: Bryan O'Donoghue<bryan.odonoghue@xxxxxxxxxx>
> >
> > Switch frame_sync_en to true to track and consume SOF/EOF data.
> >
> > Tested-by: Bryan O'Donoghue<bryan.odonoghue@xxxxxxxxxx> # x1e CRD
> > Signed-off-by: Bryan O'Donoghue<bryan.odonoghue@xxxxxxxxxx>
> > ---
> Is there a reason why it's gated behind a feature flag? Will
> exposing a SOF seq counter that's always zero (i.e. not
> implemented, never bumped) have negative consequences on
> userspace?
>
> Conversely, what information (i.e. platform list) are you
> lacking that would let us make this non-opt-in?
>
> Konrad

Yes.

To be in-spece we should already be incrementing vb.sequence not on 
every RX data-frame but on every MIPI_CSI2.SOF. You can't just return 
zero as user-space wants to know about sequence numbers.

---
bod