Re: [PATCH v2 2/2] arm64: dts: qcom: Add Xiaomi Poco M3
From: Barnabás Czémán
Date: Mon Nov 02 2026 - 15:12:31 EST
On 2026-11-02 11:44, Konrad Dybcio wrote:
On 11/1/26 8:44 PM, Barnabás Czémán wrote:I have checked it seems lemon have same adsp region like citrus.
On 2026-11-01 17:49, Amir Hanip wrote:
On Fri, 30 Oct 2026 13:30:28 +0100, Barnabas Czeman wrote:If there are no overlaps the bigger range could work for both of them.
Poco M3 (citrus) is same HW like Redmi 9T (lime) and Remi 9T NFC
(lemon) basically is a lime with NFC.
So i think it would be better make a common base from lemon's
devicetree instead of making the same devicetree again for the
different variants where only the compatible and the model property
will be the difference.
Check sm6115-xiaomi-gingkgo-common for example, it was the same case
for Redmi Note 8 (ginkgo) and 8T (willow).
Hi Barnabas, Adam,
Thanks for the review, that makes sense. I am preparing a v3 that
moves the shared parts of lemon into sm6115-xiaomi-lime-common.dtsi
and has both lemon and citrus include it. I used the name lime-common
following your naming. Happy to rename it.
Plan for v3:
1. dt-bindings (unchanged)
2. lemon: move the shared nodes into the common dtsi, no functional
change intended
3. citrus on top of the common dtsi
I can only test citrus. I do not own a Redmi 9T, so lemon is untested
on hardware. Instead, I compared the lemon DTS before and after the
split, normalized with dtc (dtc -I dts -O dts -s). The only
difference is the numbering of two auto-generated phandles. I will
describe the check in the cover letter. Adam,
would you be able to test lemon once v3 is posted, or look at the
split beforehand?
The IPA carve-outs (pil_ipa_fw_mem and pil_ipa_gsi_mem) are identical
on both, so they now live in the common dtsi.
I kept the following per variant because I cannot tell whether they
are real hardware differences or just differences between the stock
firmware images:
- ADSP carve-out: 0x53800000/0x2200000 on citrus, 0x53400000/0x2600000
on lemon. Both regions end at 0x55a00000, so only the start and
size differ. I can only confirm that the citrus value works on my
device.
Waste of precious RAM!
`pil_adsp_region@53800000`
Konrad