Re: [PATCH v4 2/2] ASoC: es8328: set SLRCK for the ES8388

[Mark Brown]

> The ES8388 has a single LRCK pin, so the DAC and the ADC have to take
> their frame clock from that one pin.  With SLRCK clear, which is the
> power-on default, the capture path never gets a frame clock and records
> digital silence while playback keeps working, so boards look like they
> have a dead microphone.

> +	if (es8328->type == ES8328_TYPE_ES8388) {
> +		ret = snd_soc_component_write(component, ES8328_DACCONTROL21,
> +					      ES8328_DACCONTROL21_SLRCK);
> +		if (ret)
> +			goto err_slrck;

...

> +err_slrck:
> +	clk_disable_unprepare(es8328->clk);
> +

This is sensible unwinding, but there were two of these unprepares
added in the first patch directly in the if rather than jumping to a
common label.  The label should be added and used in patch 1.

-- 
Mark Brown <broonie@xxxxxxxxxx>