Re: [PATCH] media: uvcvideo: Add UVC_QUIRK_CTL_MSG_DELAY_1M for HIK camera

[Kuangyi Chiang]

Hi,

Thanks for the review.

Hans de Goede <hansg@xxxxxxxxxx> 於 2026年10月29日週四 下午8:46寫道：
>
> Hi,
>
> On 29-Oct-26 4:31 AM, Kuangyi Chiang wrote:
> > UVC control requests issued when preparing a video stream sometimes
> > time out on the HIK 1080P Camera (2bdf:0280):
> >
> > [   48.363671] uvcvideo: Found UVC 1.00 device HIK 1080P Camera (2bdf:0280)
> > [   53.465662] uvcvideo: Failed to set UVC probe control : -110 (exp. 26).
> > [   58.585653] uvcvideo: Failed to query (129) UVC probe control : -110 (exp. 26).
> > [   58.592967] uvcvideo: Failed to initialize the device (-5).
> >
> > Adding a 1ms delay after each control message avoids the issue.
> >
> > Introduce UVC_QUIRK_CTL_MSG_DELAY_1M for this device.
> >
> > Signed-off-by: Kuangyi Chiang <ki.chiang65@xxxxxxxxx>
>
> Is this a USB-2.0 camera connected to a XHCI controller ?
>
> And if yes, how old is this camera model ?

Yes, it's a USB 2.0 high-speed camera connected to an xHCI
controller.

It's an entry-level 1080p USB webcam from Hikvision that has
been available for several years.

The enumeration log is shown below:

[  421.245199] usb 5-3: new high-speed USB device number 2 using xhci_hcd
[  421.368603] usb 5-3: New USB device found, idVendor=2bdf,
idProduct=0280, bcdDevice=13.00
[  421.372056] usb 5-3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[  421.372064] usb 5-3: Product: HIK 1080P Camera
[  421.372069] usb 5-3: Manufacturer: 04004000_P040200_SN0002
[  421.372072] usb 5-3: SerialNumber: 04004000_P040200_SN0002

So far, we have reproduced the issue with these xHCI hosts:

ASMedia ASM1142 (1b21:1242)
Etron EJ168 (1b6f:7023)
Etron EJ188 (1b6f:7052)
Intel xHCI (8086:8d31)

>
> The reason why I'm asking this is because the EHCI USB-2.0 controller
> interface causes a natural delay between consecutive ctrl commands queued
> one by one till the start of the next USB frrame, so they get spaced
> 1 ms apart.
>
> Where as the modern XHCI controller interface will put these back-to-back
> on the USB bus. We've seen some issues with (older) USB devices before where
> they needed some delay because they were originally only validated with
> EHCI controllers and the hw/ff assumes it will get some "breathing space"
> between control messages.

Thanks for the explanation. That makes sense.

The camera works with the EHCI host we tested without any
additional delay.

We haven't observed this issue during device enumeration.

In our tests, adding a 1 ms delay to both the UAC and UVC
control request paths prevented the timeouts.

When the delay was added to only one driver, we still observed
control transfer timeouts (-110) in the other driver.

We also submitted a similar patch for the USB audio driver,
using the existing QUIRK_FLAG_CTL_MSG_DELAY_1M:

https://lore.kernel.org/linux-sound/20261029032856.7100-1-ki.chiang65@xxxxxxxxx/T/#u

Regards,
Kuangyi

>
> Regards,
>
> Hans
>
>
>
> > ---
> >  drivers/media/usb/uvc/uvc_driver.c |  9 +++++++++
> >  drivers/media/usb/uvc/uvc_video.c  | 10 ++++++++--
> >  drivers/media/usb/uvc/uvcvideo.h   |  1 +
> >  3 files changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index e289cc7..c720d75 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -3162,6 +3162,15 @@ static const struct usb_device_id uvc_ids[] = {
> >         .bInterfaceSubClass   = 1,
> >         .bInterfaceProtocol   = 0,
> >         .driver_info          = UVC_INFO_QUIRK(UVC_QUIRK_FORCE_BPP) },
> > +     /* HIK 1080P Camera */
> > +     { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> > +                             | USB_DEVICE_ID_MATCH_INT_INFO,
> > +       .idVendor             = 0x2bdf,
> > +       .idProduct            = 0x0280,
> > +       .bInterfaceClass      = USB_CLASS_VIDEO,
> > +       .bInterfaceSubClass   = 1,
> > +       .bInterfaceProtocol   = 0,
> > +       .driver_info          = UVC_INFO_QUIRK(UVC_QUIRK_CTL_MSG_DELAY_1M) },
> >       /* Insta360 Link */
> >       { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> >                               | USB_DEVICE_ID_MATCH_INT_INFO,
> > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> > index fc3536a..4667f86 100644
> > --- a/drivers/media/usb/uvc/uvc_video.c
> > +++ b/drivers/media/usb/uvc/uvc_video.c
> > @@ -35,13 +35,19 @@ static int __uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit,
> >  {
> >       u8 type = USB_TYPE_CLASS | USB_RECIP_INTERFACE;
> >       unsigned int pipe;
> > +     int ret;
> >
> >       pipe = (query & 0x80) ? usb_rcvctrlpipe(dev->udev, 0)
> >                             : usb_sndctrlpipe(dev->udev, 0);
> >       type |= (query & 0x80) ? USB_DIR_IN : USB_DIR_OUT;
> >
> > -     return usb_control_msg(dev->udev, pipe, query, type, cs << 8,
> > -                     unit << 8 | intfnum, data, size, timeout);
> > +     ret = usb_control_msg(dev->udev, pipe, query, type, cs << 8,
> > +                           unit << 8 | intfnum, data, size, timeout);
> > +
> > +     if (dev->quirks & UVC_QUIRK_CTL_MSG_DELAY_1M)
> > +             usleep_range(1000, 2000);
> > +
> > +     return ret;
> >  }
> >
> >  static const char *uvc_query_name(u8 query)
> > diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> > index b6bcee4..1426d14 100644
> > --- a/drivers/media/usb/uvc/uvcvideo.h
> > +++ b/drivers/media/usb/uvc/uvcvideo.h
> > @@ -81,6 +81,7 @@
> >  #define UVC_QUIRK_INVALID_DEVICE_SOF 0x00010000
> >  #define UVC_QUIRK_MJPEG_NO_EOF               0x00020000
> >  #define UVC_QUIRK_MSXU_META          0x00040000
> > +#define UVC_QUIRK_CTL_MSG_DELAY_1M   0x00080000
> >
> >  /* Format flags */
> >  #define UVC_FMT_FLAG_COMPRESSED              0x00000001
>