Re: [PATCH] crypto: ixp4xx - Free the fallback cipher if context initialization fails
From: Krzysztof Kozlowski
Date: Tue Nov 03 2026 - 02:11:35 EST
On 03/11/2026 07:29, Wentao Liang wrote:
> init_tfm_ablk() allocates a fallback skcipher before calling init_tfm().
> If allocating either security association context fails, init_tfm()
> returns an error and the fallback is left allocated. The crypto core
> does not call the algorithm exit callback after a failed initialization,
> so exit_tfm_ablk() cannot release it.
>
> Free the fallback cipher when init_tfm() fails. The security association
> contexts are already unwound by init_tfm().
>
> Fixes: dfb098d692ea ("crypto: ixp4xx - fallback when having more than one SG")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
Another fake identity of "vulab" doing exactly the same as other cases,
repeating same mistake of running unsupervised crappy bot even though
was asked multiple times to fix that.
Best regards,
Krzysztof