Re: [PATCH v2] hfsplus: free failed b-tree nodes in hfs_bnode_put()
From: Markus Elfring
Date: Tue Nov 03 2026 - 03:20:22 EST
…
> +++ b/fs/hfsplus/bnode.c
> @@ -702,6 +702,14 @@ void hfs_bnode_put(struct hfs_bnode *node)
> hfs_bnode_free(node);
> return;
> }
> +
> + if (test_bit(HFS_BNODE_ERROR, &node->flags)) {
> + hfs_bnode_unhash(node);
> + spin_unlock(&tree->hash_lock);
> + hfs_bnode_free(node);
> + return;
> + }
> +
> spin_unlock(&tree->hash_lock);
> }
> }
Would you dare to use an additional label in such a function implementation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.4-rc1#n526
https://elixir.bootlin.com/linux/v7.3/source/fs/hfs/bnode.c#L513-L542
Regards,
Markus