Re: [PATCH 1/8] mm: remove wait_on_page_writeback()

[Lorenzo Stoakes (ARM)]

On Mon, Nov 02, 2026 at 05:54:06PM -0500, Tal Zussman wrote:
> The last caller was converted to folio_wait_writeback(), so drop the
> wait_on_page_writeback() compatibility wrapper and its declaration.
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>

LGTM!

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

> ---
>  include/linux/pagemap.h | 1 -
>  mm/folio-compat.c       | 6 ------
>  2 files changed, 7 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 73af18a37367..c0f7c06dc6fd 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -1299,7 +1299,6 @@ static inline int folio_wait_locked_killable(struct folio *folio)
>  }
>
>  void folio_end_read(struct folio *folio, bool success);
> -void wait_on_page_writeback(struct page *page);
>  void folio_wait_writeback(struct folio *folio);
>  int folio_wait_writeback_killable(struct folio *folio);
>  void end_page_writeback(struct page *page);
> diff --git a/mm/folio-compat.c b/mm/folio-compat.c
> index 6212fdd6761a..f880110ac980 100644
> --- a/mm/folio-compat.c
> +++ b/mm/folio-compat.c
> @@ -23,12 +23,6 @@ void end_page_writeback(struct page *page)
>  }
>  EXPORT_SYMBOL(end_page_writeback);
>
> -void wait_on_page_writeback(struct page *page)
> -{
> -	return folio_wait_writeback(page_folio(page));
> -}
> -EXPORT_SYMBOL_GPL(wait_on_page_writeback);
> -
>  void mark_page_accessed(struct page *page)
>  {
>  	folio_mark_accessed(page_folio(page));
>
> --
> 2.39.5
>

--
Cheers, Lorenzo