Re: [PATCH 2/8] mm: remove end_page_writeback()

[Lorenzo Stoakes (ARM)]

On Mon, Nov 02, 2026 at 05:54:07PM -0500, Tal Zussman wrote:
> There are no callers left. Update the two comments that still named
> it to refer to folio_end_writeback().
>
> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>

LGTM!

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

> ---
>  include/linux/pagemap.h   | 1 -
>  include/linux/writeback.h | 2 +-
>  mm/folio-compat.c         | 6 ------
>  mm/migrate.c              | 2 +-
>  4 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index c0f7c06dc6fd..692ce3867a1d 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -1301,7 +1301,6 @@ static inline int folio_wait_locked_killable(struct folio *folio)
>  void folio_end_read(struct folio *folio, bool success);
>  void folio_wait_writeback(struct folio *folio);
>  int folio_wait_writeback_killable(struct folio *folio);
> -void end_page_writeback(struct page *page);
>  void folio_end_writeback(struct folio *folio);
>  void folio_end_writeback_no_dropbehind(struct folio *folio);
>  void folio_end_dropbehind(struct folio *folio);
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index b749a9a5a5ee..c50f404141b0 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -124,7 +124,7 @@ struct wb_domain {
>  	 * writeout speed.
>  	 *
>  	 * We do this by keeping a floating proportion between BDIs, based
> -	 * on page writeback completions [end_page_writeback()]. Those
> +	 * on page writeback completions [folio_end_writeback()]. Those
>  	 * devices that write out pages fastest will get the larger share,
>  	 * while the slower will get a smaller share.
>  	 *
> diff --git a/mm/folio-compat.c b/mm/folio-compat.c
> index f880110ac980..9f2cd0ebfbbd 100644
> --- a/mm/folio-compat.c
> +++ b/mm/folio-compat.c
> @@ -17,12 +17,6 @@ void unlock_page(struct page *page)
>  }
>  EXPORT_SYMBOL(unlock_page);
>
> -void end_page_writeback(struct page *page)
> -{
> -	return folio_end_writeback(page_folio(page));
> -}
> -EXPORT_SYMBOL(end_page_writeback);
> -
>  void mark_page_accessed(struct page *page)
>  {
>  	folio_mark_accessed(page_folio(page));
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 94e8cd46c6db..953af633ec0d 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -859,7 +859,7 @@ void folio_migrate_flags(struct folio *newfolio, struct folio *folio)
>
>  	/*
>  	 * PG_readahead shares the same bit with PG_reclaim.  The above
> -	 * end_page_writeback() may clear PG_readahead mistakenly, so set the
> +	 * folio_end_writeback() may clear PG_readahead mistakenly, so set the
>  	 * bit after that.
>  	 */
>  	if (folio_test_readahead(folio))
>
> --
> 2.39.5
>

--
Cheers, Lorenzo