Re: [PATCH 3/7] soundwire: intel: Split PDIs and DAIs initialization

[Cezary Rojewski]

On 11/3/2026 3:35 AM, Liao, Bard wrote:

>> +int sdw_intel_init_pdis(struct sdw_intel *sdw);
>>
>>  /* common bank switch routines */
>>  int intel_pre_bank_switch(struct sdw_intel *sdw);
>> diff --git a/drivers/soundwire/intel_auxdevice.c
>> b/drivers/soundwire/intel_auxdevice.c
>> index 5983fbc5725a..114dadedfa14 100644
>> --- a/drivers/soundwire/intel_auxdevice.c
>> +++ b/drivers/soundwire/intel_auxdevice.c
>> @@ -423,6 +423,10 @@ int intel_link_startup(struct auxiliary_device *auxdev)
>>  	if (ret)
>>  		goto err_init;
>>
>> +	ret = sdw_intel_init_pdis(sdw);
> 
> intel_link_startup will be called by all Intel platforms, but the PDI
> initialization are different for the ACE2+ platforms. Please call
> sdw_intel_init_pdi in one of the sdw_intel_hw_ops ops.

Indeed. I'll add a new ops, init_pdis(), and update the ACE2+ related
code. When I've created these, around 2021, the ACE2+ wasn't there and
right now, avs-driver does not utilize SDW with ACE2+ either so nothing
shown in the tests.

Thank you, Bard!

>> +	if (ret)
>> +		goto err_init;
> 
> This is after sdw_intel_link_power_up(), please goto err_power_up
Ack.