Re: [PATCH v5 5/9] xfs: cap the block count of xfs_iomap_write_direct() at one extent
From: Carlos Maiolino
Date: Tue Nov 03 2026 - 04:05:52 EST
On Tue, Nov 03, 2026 at 06:49:22AM +0100, Christoph Hellwig wrote:
> On Thu, Oct 29, 2026 at 11:23:02AM +0900, Daejun Park via B4 Relay wrote:
> > From: Daejun Park <daejun7.park@xxxxxxxxxxx>
> >
> > xfs_iomap_write_direct() reserves blocks for the whole count in an
> > unsigned int. For a pNFS layout the client chooses that count, and an
> > RW LAYOUTGET for 16 TiB wraps the reservation and shuts XFS down.
> >
> > xfs_bmapi_write() maps at most XFS_MAX_BMBT_EXTLEN blocks here, so cap
> > the count at that. nfsd asks again for the rest. The other callers get
> > the same mapping as before.
> >
> > Suggested-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/20261008154017.GO2705364@frogsfrogsfrogs
> > Suggested-by: Christoph Hellwig <hch@xxxxxx>
> > Link: https://lore.kernel.org/r/20261015060932.GD14035@xxxxxx
> > Suggested-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> > Link: https://lore.kernel.org/r/atoImJxtg70XcIjS@quentin
>
> I think this is overdoing it a bit with the Link tags.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
>
Yeah, I agree. I'll just rip off the Links when applying