Re: [PATCH 4/8] mm: remove attach_page_private() and detach_page_private()

From: Lorenzo Stoakes (ARM)

Date: Tue Nov 03 2026 - 04:11:24 EST


On Mon, Nov 02, 2026 at 05:54:09PM -0500, Tal Zussman wrote:
> There are no callers left of either wrapper. Remove them.
>
> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>

LGTM!

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>

> ---
> include/linux/pagemap.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 9adfeae2153c..37b7786350c5 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -635,16 +635,6 @@ static inline void *folio_detach_private(struct folio *folio)
> return data;
> }
>
> -static inline void attach_page_private(struct page *page, void *data)
> -{
> - folio_attach_private(page_folio(page), data);
> -}
> -
> -static inline void *detach_page_private(struct page *page)
> -{
> - return folio_detach_private(page_folio(page));
> -}
> -
> #ifdef CONFIG_NUMA
> struct folio *filemap_alloc_folio_noprof(gfp_t gfp, unsigned int order,
> struct mempolicy *policy);
>
> --
> 2.39.5
>

--
Cheers, Lorenzo