Re: [PATCH RFC] arm64: dts: qcom: nord: add ADC-TM thermistor channels for Nord PMICs

[Bartosz Golaszewski]

On Tue, Nov 03, 2026 at 04:28:42PM +0800, Shawn Guo wrote:
> On Fri, Oct 30, 2026 at 10:28:21AM +0100, Bartosz Golaszewski wrote:
> > On Wed, Oct 28, 2026 at 11:01:03PM +0800, Shawn Guo wrote:
> > > From: Dhruvin Rajpura <dhruvin.rajpura@xxxxxxxxxxxxxxxx>
> > > 
> > > PMAU0102 (Kai_MV) and PMM8650AU's Kobra_MM ADC5 Gen3 controllers only
> > > expose REF_GND/1P25VREF/DIE_TEMP calibration channels; none of their
> > > AMUX thermistor pins are wired up, so none of the board thermistor
> > > rails feed the thermal framework.
> > > 
> > > Only 3 AMUX pins are actually wired to thermistors on Nord, all on
> > > Kai and none on Kobra: Kai instance E's AMUX1 (SDRAM3 THERM) and Kai
> > > instance I's AMUX1/AMUX2 (SDRAM1 THERM, UFS THERM). Kai's other AMUX
> > > pins are either DO_NOT_USE or wired to voltage-rail monitors, not
> > > thermistors, so add only these 3 channels.
> > > 
> > > Add #thermal-sensor-cells = <1> to the two Kai adc@ nodes that gain
> > > a channel, the new AMUX1[/AMUX2]_THM channel(s) with qcom,adc-tm,
> > > and a per-channel thermal-zone for each, following the existing
> > > Gen3/Gen4 board pattern of a direct thermal-sensors phandle into the
> > > ADC channel.
> > > 
> > > Signed-off-by: Dhruvin Rajpura <dhruvin.rajpura@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> > > ---
> > 
> > ...
> > 
> > > +
> > >  		pmau0102_f_thermal: pmau0102-f-thermal {
> > >  			polling-delay-passive = <100>;
> > >  			thermal-sensors = <&pmau0102_f_mbg_temp>;
> > > @@ -501,6 +545,42 @@ trip0 {
> > >  			};
> > >  		};
> > >  
> > > +		pmau0102_i_sdram1_thermal: pm-i-sdram1-thermal {
> > 
> > Existing thermal zone nodes use the "pmau0102" prefix.
> 
> Hi Bartosz,
> 
> Following up on this: "pmau0102-e-sdram3-thermal" exceeds the
> thermal-zones.yaml node name limit (11 chars before "-thermal").
> Since v2 moves these zones into the board DTs per Konrad's comment,
> I will name them after the measured component, i.e. sdram3-thermal,
> sdram1-thermal and ufs-thermal, like other boards do. I will drop
> your Acked-by in v2 as the patch changes quite a bit.
>

Sounds good!

Thanks,
Bartosz