Re: [PATCH v2 1/2] media: i2c: vd55g1: Mark the AE lock and bias controls inactive in manual mode

From: Fernando Rimoli

Date: Tue Nov 03 2026 - 06:37:05 EST


Hi Sakari,

On Mon, Nov 02, 2026 at 02:08:40PM +0200, Sakari Ailus wrote:
> I don't think grabbing a control is a bug as such; it's normal that if
> exposure is set to auto, you can't access the manual exposure controls.

For that case the framework itself uses inactive rather than grabbed:
v4l2_ctrl_auto_cluster() sets V4L2_CTRL_FLAG_INACTIVE on the manual
controls while the cluster is in auto, and vd55g1 already uses it for
its exposure cluster. The AE lock and bias are the mirror image,
auto-only controls in manual mode, so this patch makes them follow the
same rule.

That also matches the flag descriptions in vidioc-queryctrl.rst: grabbed
is "temporarily unchangeable, for example because another application
took over control of the respective resource", inactive is "not
applicable to the current configuration".

vd56g3 has the same two __v4l2_ctrl_grab() calls. If this goes in, I can
send the same change for it.

Fernando