Re: [PATCH] vhost/vringh: reject zero-length indirect descriptor tables

From: Michael S. Tsirkin

Date: Tue Nov 03 2026 - 06:42:31 EST


On Tue, Nov 03, 2026 at 11:29:35AM +0800, Fang Xieyan wrote:
> Hi Michael,
>
> Yes, same fix - sorry. The October 21 posting is a duplicate
> of the v2 I posted on September 26:
>
> https://lore.kernel.org/virtualization/20260926160755.21485-1-fangxy@xxxxxxxxxxxx/
>
> I resent it as a new patch instead of a v3.
>
> The !len form is equivalent to v2's len < sizeof(struct
> vring_desc) check when combined with the modulo check -
> zero is the only length below one descriptor that is also
> a multiple of the descriptor size.
>
> The diagnostic change is to pass the byte-order converted
> len instead of the raw desc->len, so the reported length is
> correct when the vring byte order differs from the CPU byte
> order.
>
> Would you prefer that I send a v3 on the original v2 thread
> with this diagnostic correction, or should I drop the
> October 21 posting and leave v2 as is?
>
> Thanks,
> Fang

pls take a look at my tree, vhost branch. if you want any
changes made wrt that, pls let me know.

--
MST