[PATCH] scripts: check-function-names: propagate nm failures
From: Hamdy Abou El Anein
Date: Tue Nov 03 2026 - 06:52:17 EST
From: Hamdy Abou El Anein <hamdy.aea@xxxxxxxxxxxxxx>
The symbol-name check pipes nm through awk and grep. If nm cannot read
an object file, its failure status is lost and the script reports
success without checking any symbols.
Capture nm output before filtering it and fail when nm fails. This
keeps the existing forbidden-name detection unchanged.
Tested with a malformed object (failure), a valid object (success),
and an object defining startup (failure).
Signed-off-by: Hamdy Abou El Anein <hamdy.aea@xxxxxxxxxxxxxx>
---
scripts/check-function-names.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/check-function-names.sh b/scripts/check-function-names.sh
index 94883e6..f07a0e1 100755
--- a/scripts/check-function-names.sh
+++ b/scripts/check-function-names.sh
@@ -13,7 +13,8 @@ if [ ! -f "$objfile" ]; then
exit 1
fi
-bad_symbols=$(${NM:-nm} -p "$objfile" | awk '$2 ~ /^[TtWw]$/ {print $3}' |
+symbols=$(${NM:-nm} -p "$objfile") || exit 1
+bad_symbols=$(printf '%s\n' "$symbols" | awk '$2 ~ /^[TtWw]$/ {print $3}' |
grep -E '^(startup|exit|split|unlikely|hot|unknown)(\.|$)')
if [ -n "$bad_symbols" ]; then
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.56.0