[PATCH] of: unittest: fix node reference leak in of_unittest_dynamic()

From: Wentao Liang

Date: Tue Nov 03 2026 - 08:02:36 EST


of_find_node_by_path() returns a device_node with its reference count
incremented. of_unittest_dynamic() only returns directly on the
allocation failure path and otherwise falls off the end of the
function, so the reference is never dropped.

Release the reference on both exits.

Fixes: 7e66c5c74f73 ("of/selftest: Add self tests for manipulation of properties")
Cc: stable@xxxxxxxxxxxxxxx
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
---
drivers/of/unittest.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 7426d13e9958..d2f5c7ef3178 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -200,6 +200,7 @@ static void __init of_unittest_dynamic(void)
prop = kzalloc_objs(*prop, 4);
if (!prop) {
unittest(0, "kzalloc() failed\n");
+ of_node_put(np);
return;
}

@@ -244,6 +245,8 @@ static void __init of_unittest_dynamic(void)
if (prop->value)
unittest(of_add_property(np, prop) == 0,
"Adding a large property should have passed\n");
+
+ of_node_put(np);
}

static int __init of_unittest_check_node_linkage(struct device_node *np)
--
2.34.1