Re: [PATCH 1/1] spi: use dmaengine_desc_set_callback()
From: Alain Volmat
Date: Tue Nov 03 2026 - 08:12:36 EST
On Mon, Nov 02, 2026 at 12:39:58PM -0500, Frank.Li@xxxxxxxxxxx wrote:
> From: Frank Li <Frank.Li@xxxxxxx>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper across SPI bus drivers.
>
> No functional change intended. Prepare make to struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> drivers/spi/atmel-quadspi.c | 3 +--
> drivers/spi/spi-at91-usart.c | 3 +--
> drivers/spi/spi-atcspi200.c | 3 +--
> drivers/spi/spi-atmel.c | 3 +--
> drivers/spi/spi-bcm2835.c | 6 ++----
> drivers/spi/spi-cadence-quadspi.c | 3 +--
> drivers/spi/spi-davinci.c | 6 ++----
> drivers/spi/spi-dw-dma.c | 6 ++----
> drivers/spi/spi-ep93xx.c | 3 +--
> drivers/spi/spi-fsl-dspi.c | 6 ++----
> drivers/spi/spi-fsl-lpspi.c | 6 ++----
> drivers/spi/spi-geni-qcom.c | 3 +--
> drivers/spi/spi-img-spfi.c | 6 ++----
> drivers/spi/spi-imx.c | 6 ++----
> drivers/spi/spi-ingenic.c | 3 +--
> drivers/spi/spi-mxs.c | 3 +--
> drivers/spi/spi-nxp-xspi.c | 3 +--
> drivers/spi/spi-omap2-mcspi.c | 6 ++----
> drivers/spi/spi-pic32.c | 3 +--
> drivers/spi/spi-pl022.c | 3 +--
> drivers/spi/spi-pxa2xx-dma.c | 3 +--
> drivers/spi/spi-qup.c | 3 +--
> drivers/spi/spi-rockchip.c | 6 ++----
> drivers/spi/spi-rspi.c | 6 ++----
> drivers/spi/spi-rzv2h-rspi.c | 3 +--
> drivers/spi/spi-s3c64xx.c | 3 +--
> drivers/spi/spi-sh-msiof.c | 6 ++----
> drivers/spi/spi-spacemit-k1.c | 3 +--
> drivers/spi/spi-stm32-ospi.c | 3 +--
> drivers/spi/spi-stm32-qspi.c | 3 +--
> drivers/spi/spi-stm32.c | 9 +++------
For the spi-stm32.c
Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
Regards,
Alain