Re: [PATCH 02/13] wifi: brcmfmac: Match complete firmware capability names

[Arend van Spriel]

On Fri, 25 Sep 2026 23:43:37 +1000, Michael Reeves <michael.reeves077@xxxxxxxxx> wrote:
> From: Michael Reeves <michael.reeves077@xxxxxxxxx>
>
> BCM4388 firmware advertises "hp2p" without advertising "p2p". Substring
> matching incorrectly treats "hp2p" as P2P support, causing userspace to
> attempt Wi-Fi Direct interface creation that the firmware rejects.
>
> Match complete whitespace-separated capability names instead. Remove the
> trailing-space workarounds for SAE and FBT and reserve a terminating
> byte outside the firmware response buffer.
>
> Fixes: ec64241c9fd2 ("brcmfmac: obtain feature info using 'cap' firmware command")

Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

Regards,
Arend

> Signed-off-by: Michael Reeves <michael.reeves077@xxxxxxxxx>
> ---
>  .../wireless/broadcom/brcm80211/brcmfmac/feature.c   | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)