Re: [PATCH] ALSA: hda: cs35l41: Add DSD properties for ASUS UX582Z (1043:1a8f)

[Takashi Iwai]

On Fri, 30 Oct 2026 18:03:54 +0100,
Slaton Christie wrote:
> 
> The ASUS Zenbook Pro Duo 15 UX582Z with PCI SSID 1043:1a8f has two
> CS35L41 amplifiers on SPI (CSC3551), but its BIOS provides no _DSD
> properties for them, so the amps fail to probe and the internal
> speakers are silent:
> 
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Failed property cirrus,dev-index: -22
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: error -EINVAL: Platform not supported
> 
> The Realtek codec quirk for this SSID already exists
> (ALC245_FIXUP_CS35L41_SPI_2), and linux-firmware already ships the
> tuned cs35l41-dsp1-spk-prot-10431a8f-* files. Only the property table
> entry is missing.
> 
> Add an entry using the same configuration as the sibling UX582ZS
> (1043:12af): internal boost, CS/reset/speaker-ID GPIOs at indices
> 0/1/2, 1000nH inductor, 4500mA peak, 24uF capacitor.
> 
> Tested on a UX582Z running 7.3.0 (CachyOS) with the change built as a
> DKMS module: both amps probe, load the spk-prot firmware, apply the
> EFI calibration (R0=10611 / 10708) and the speakers play audio.
> 
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: Firmware Loaded - Type: spk-prot, Gain: 17
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 10431A8F, BST: 0, VSPK: 0, CH: L, FW EN: 1, SPKID: 0
>   cs35l41-hda spi1-CSC3551:00-cs35l41-hda.1: CS35L41 Bound - SSID: 10431A8F, BST: 0, VSPK: 0, CH: R, FW EN: 1, SPKID: 0
> 
> The boost values are copied from the 1043:12af entry, not taken from
> ASUS or Cirrus documentation; confirmation of the boost parameters by
> Cirrus would be appreciated.
> 
> The diagnosis and the patch were prepared with the help of an AI
> assistant (Claude, Anthropic), from the dmesg output above and the
> existing 1043:12af table entry; testing was done on real hardware by
> the submitter.
> 
> Cc: stable@xxxxxxxxxxxxxxx

You forgot Signed-off-by tag?  Please resubmit with it.


thanks,

Takashi