Re: [PATCH v2] net: wwan: iosm: drop redundant skb->data check in MUX DL decode
From: Andrew Lunn
Date: Tue Nov 03 2026 - 10:08:13 EST
On Tue, Nov 03, 2026 at 07:11:01PM +0800, Fang Xieyan wrote:
> The skb passed to ipc_mux_dl_decode() through the current RX path
> always has a valid data pointer.
>
> The only caller, ipc_imem_dl_skb_process(), checks for a NULL skb
> before calling ipc_mux_dl_decode(). The skb is allocated through
> ipc_pcie_alloc_skb() -> ipc_pcie_alloc_local_skb() ->
> __netdev_alloc_skb(), which provides a valid data buffer on
> successful allocation. Allocation or DMA mapping failures return
> a NULL skb instead.
>
> Remove the redundant skb->data check.
>
> Suggested-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> Reviewed-by: Guanglei Zhu <zhugl3@xxxxxxxxxxxx>
> Signed-off-by: Fang Xieyan <fangxy@xxxxxxxxxxxx>
> ---
> Changes in v2:
Please always start a new thread for a new version of the patch. The
CI system does not always pick up the patch and run it.
Please also read:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
---
pw-bot: cr