Re: [PATCH v3] Docs/admin-guide/mm/damon/reclaim: improve language

From: SJ Park

Date: Tue Nov 03 2026 - 10:16:55 EST


Hello Manuel,

On Tue, 3 Nov 2026 13:00:42 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:

> Fix upper case. Fix tenses. Replace 'set as' with 'set to'. Add space after

Please wrap lines for 75 chars per line, from the next time. Otherwise,
checkpatch.pl will warn like below:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

> sentence to make it double space. Rewrite and refine complex sentences.
>
> CC: Aveline Noir <jm5905938@xxxxxxxxx>
> Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> ---
> That's the final version.

Thank you for revisioning.

[...]
> --- a/Documentation/admin-guide/mm/damon/reclaim.rst
> +++ b/Documentation/admin-guide/mm/damon/reclaim.rst
> @@ -4,7 +4,7 @@
> DAMON-based Reclamation
> =======================
>
> -DAMON-based Reclamation (DAMON_RECLAIM) is a static kernel module that aimed to
> +DAMON-based reclamation (DAMON_RECLAIM) is a static kernel module that aimes to

Sashiko suggested [1] s/aimes/aims/ ?

[...]
> @@ -88,7 +89,7 @@ identifies the region as cold, and reclaims it.
> autotune_monitoring_intervals
> -----------------------------
>
> -If this parameter is set as ``Y``, DAMON_RECLAIM automatically tunes DAMON's
> +If this parameter is set to ``Y``, DAMON_RECLAIM automatically tunes DAMON's
> sampling and aggregation intervals. The auto-tuning aims to capture meaningful
> amount of access events in each DAMON-snapshot, while keeping the sampling
> interval 5 milliseconds in minimum, and 10 seconds in maximum. Setting this as

Sashiko also suggested [1] to update above 'Setting this as' to 'Setting this
to'.

Other than above two,

Reviewed-by: SJ Park <sj@xxxxxxxxxx>

Assuming you don't mind accepting above two Sashiko suggestions, I applied this
patch with the suggested changes to damon/next [1] tree. I will repost it soon
(~1 week) as an mm.git merge request. So, no action from your side is needed
for now.

[1] https://lore.kernel.org
[2] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]