Re: [PATCH 1/2] mac80211: move static function from header to referenced file

[Omer El Idrissi]

> On 10/30/2026 6:21 AM, Omer El Idrissi wrote:
> > > > Move static function from header file to only c file it's used in.
> > > why? all the drv_ inlines are in driver-ops.h
> > >
> > > first rule of commit text is to describe the problem you are tying to solve.
> > >
> > > don't add unnecessary churn to the wireless code.
> > i moved it because multiple files include the header and when those are
> > compiled they don't see the tracepoint definition because the next patch
> > ifdef guards it under the same config that enables the only file the
> > static function that uses the tracepoint is called from.
> >
> > this static function was only used in that file and i didn't see any
> > obvious reason for it's existance in that header so i moved it to the
> > file where it's used.
> >
> > commit messages are kept in the git history. should i send a v2 with a
> > better commit message? or is the patch series problematic otherwise?
> I can't speak for Johannes (wireless maintainer) but I would not accept these
> patches. There are thousands of patches active in wireless, many of which
> solve real problems, so the maintainers usually don't have time for "noise"
> patches. I have over 400 patches in my ath.git queue alone.
>
> /jeff

i suggest you take this to your local union. i'm sure they can help you 
negotiate for less inhumane employment conditions.