Re: xfs: fix temporary cursor leak in btree shift corruption paths

[Markus Elfring]

> Thanks for the review and the suggestion. I agree that centralizing
> the error handling paths in these functions would improve readability.

Further adjustment possibilities might be evolving.


> However, to keep this patch focused strictly on the cursor leak fix
> (as per the 'one patch, one thing' principle), I would prefer to
> submit the code clean-up as a separate follow-up patch if that's
> acceptable.

This can be the case.
Related constraints can eventually be reconsidered also for clean-up patches
in combination with growing number for fixes.


>             I will review the affected functions and see if there are
> any obvious style issues worth addressing.

Would you find another clarification approach helpful?

[RFC] Replacing special goto statements by direct returns?
https://lore.kernel.org/kernel-janitors/52418f50-b3ff-461d-8e66-c10f70e35b2a@xxxxxx/

Regards,
Markus