Re: [PATCH net-next] net: stmmac: selftests: Add missing endianness conversions

[Lorenzo Bianconi]

> The kbuild bot found some endianness issues in the stmmac ethtool
> selftests [1] let's address these.
> 
> In practice these missing conversions didn't cause any issue, as the
> masks / values on which the conversions were missing were either always
> 0 or ~0, so skipping the byte swaps lead to the same value being passed
> anyway.
> 
> [1]: https://lore.kernel.org/oe-kbuild-all/202611010511.Mk620DTd-lkp@xxxxxxxxx/
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>

Reviewed-by: Lorenzo Bianconi <lorenzo.bianconi@xxxxxxxxxxxxxxxx>

> ---
> This isn't worth sending to net, I've dropped the Fixes / Reported-by /
> Closes tags, let me know if I should add'em back.
> 
> There are more of these endianness warnings in other places, but they
> require a bit more attention. This'll be addressed at a later point, I
> don't think we have many big-endian stmmac setups anyways.
> 
>  drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
> index 40811df8f2b7..df696e2c1528 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
> @@ -1216,7 +1216,7 @@ static int stmmac_test_rxp(struct stmmac_priv *priv)
>  	sel->offshift = 0;
>  	sel->keys[0].off = 6;
>  	sel->keys[0].val = htonl(0xdeadbeef);
> -	sel->keys[0].mask = ~0x0;
> +	sel->keys[0].mask = htonl(~0x0);
>  
>  	ret = stmmac_tc_setup_cls_u32(priv, priv, &cls_u32);
>  	if (ret)
> @@ -1463,8 +1463,8 @@ static int __stmmac_test_l3filt(struct stmmac_priv *priv, u32 dst, u32 src,
>  
>  	key.src = htonl(src);
>  	key.dst = htonl(dst);
> -	mask.src = src_mask;
> -	mask.dst = dst_mask;
> +	mask.src = htonl(src_mask);
> +	mask.dst = htonl(dst_mask);
>  
>  	cls->rule = rule;
>  
> @@ -1594,8 +1594,8 @@ static int __stmmac_test_l4filt(struct stmmac_priv *priv, u32 dst, u32 src,
>  	keys.key.dst = htons(dst);
>  	/* Match the full IP proto field */
>  	masks.bmask.ip_proto = 0xff;
> -	masks.mask.src = src_mask;
> -	masks.mask.dst = dst_mask;
> +	masks.mask.src = htons(src_mask);
> +	masks.mask.dst = htons(dst_mask);
>  
>  	cls->rule = rule;
>  
> -- 
> 2.56.0
> 
>

Attachment: signature.asc
Description: PGP signature