Re: [PATCH v4 4/7] net: stmmac: dwmac-meson8b: follow the generic RGMII delay rules on the T7
From: Lucas Tanure
Date: Tue Nov 03 2026 - 12:03:38 EST
On Sun, Nov 1, 2026 at 10:58 PM Martin Blumenstingl
<martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
>
> On Thu, Oct 22, 2026 at 10:06 PM Lucas Tanure <tanure@xxxxxxxxx> wrote:
> [...]
> > + if (!dwmac->data->init_delays)
> > + return dev_err_probe(dwmac->dev, -EINVAL,
> > + "missing init_delays callback\n");
> I'd rather let this crash hard to make it obvious to someone adding a
> new SoC that they forgot something.
OK, the NULL check is gone in v5.
> Other than that this looks good.
> It would be great if the netdev maintainers could comment on whether
> this now matches the approach they had in mind.