Re: [PATCH v10 03/11] ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h

[Bart Van Assche]

On 11/3/26 5:32 AM, Larisa Grigore wrote:
> Move the Tx/Rx FSM state definitions from ufshcd-dwc.h to
> include/ufs/unipro.h.
>
> These state values are UniPro/M-PHY related and are not specific to
> the DesignWare UFS host controller implementation, so unipro.h is a
> more appropriate location for sharing them.
>
> As part of this move, drop the driver-private TX_FSM_HIBERN8 define in
> ufs-hisi and ufs-qcom and repoint their Hibern8 checks at the shared
> UFS_TX_STATE_HIBERN8 enum constant. This is a no-op change.
>
> Since the definitions become visible to every user of the shared
> header, prefix the enum constants with UFS_ (e.g. RX_STATE_HIBERN8
> becomes UFS_RX_STATE_HIBERN8) to avoid polluting the global namespace,
> and update the existing AMD Versal2 users accordingly.
>
> This also prepares for using these definitions in a subsequent commit.

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>