Re: [PATCH v4 2/7] dt-bindings: net: amlogic,meson-dwmac: add amlogic,t7-dwmac

From: Lucas Tanure

Date: Tue Nov 03 2026 - 13:14:25 EST


On Mon, Nov 2, 2026 at 1:27 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + # The PHY adds the 2ns RGMII delays, see ethernet-controller.yaml.
> > + # The RX delay line of this glue is fine tuning in 200ps steps,
> > + # added on top of what phy-mode describes. The TX side has no fine
> > + # tuning: its only step is a quarter of the clock period, the full
> > + # 2ns at 1Gbit/s, so the TX property is not accepted.
> > + tx-internal-delay-ps: false
> > +
> > + rx-internal-delay-ps:
> > + enum: [200, 400, 600, 800, 1000, 1200, 1400, 1600, 1800, 2000,
> > + 2200, 2400, 2600, 2800, 3000]
>
> This is good, thanks.
>
> > +
> > + amlogic,tx-delay-ns: false
> > + amlogic,rx-delay-ns: false
>
> Maybe add a comment that these are deprecated in new SoCs favour of
> the standard {rx|tx}-internal-delay-ps properties.
Done in v5.

>
> Andrew
>