Re: [PATCH v1 5/5] iommu: Pass in reset result to pci_dev_reset_iommu_done()
From: Nicolin Chen
Date: Tue Nov 03 2026 - 15:01:53 EST
On Tue, Nov 03, 2026 at 10:33:46AM -0800, Nicolin Chen wrote:
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 3d3e95cb9f7dc..92e81460c2d8f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4416,7 +4416,7 @@ static int __pci_dev_specific_reset(struct pci_dev *dev, bool probe,
>
> ret = i->reset(dev, probe);
> if (!probe)
> - pci_dev_reset_iommu_done(dev);
> + pci_dev_reset_iommu_done(dev, ret);
Sashiko pointed out a finding against the flr in quirks:
"Can a nested FLR failure inside a device-specific reset quirk be lost,
allowing the device to be unblocked even when the underlying FLR failed?"
Justification: this is deliberately ignored, per Jason's suggestion:
https://lore.kernel.org/all/178786269177.3808739.6763094519382046767.b4-review@b4/
Nicolin