Re: [PATCH v2 0/2] drm/imagination: MMU defines updates and improvements

[Alessio Belle]

Hi Alexandru,

On Mon, 2026-10-12 at 13:20 +0300, Alexandru Dadu wrote:
> - Restrict the inclusion of MMU defines to MMU code.
> - Refactor MMU defines to use kernel style and access.

Could you rebase these patches on top of latest drm-misc-next, that now includes
all the recent MMU fixes?

Commit 789f290b2e81 ("drm/imagination: Size page table preallocation by device
address") in particular added more usages of some SHIFT defines that have
been removed by this series. It might be simplest to readd all three to
pvr_rogue_mmu_defs.h as

#define ROGUE_MMUCTRL_VADDR_[PC|PD|PT]_INDEX_SHIFT __bf_shf(ROGUE_MMUCTRL_VADDR_[PC|PD|PT]_INDEX_MASK)

following the MASK defines, plus linux/bitfield.h at the top of the file.

Also, both Gyeyoung's (v1) and Brajesh's (v2) Reviewed-by tags should be
applied.

Thanks,
Alessio

> 
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
> ---
> Changes in v2:
> - Update the pvr_page_table_l2_entry_raw_set() description to better reflect the general changes.
> - Link to v1: https://patch.msgid.link/20260930-b4-include-mmu-defines-only-in-mmu-code-v1-0-291eadfde23b@xxxxxxxxxx
> 
> To: Alessio Belle <alessio.belle@xxxxxxxxxx>
> To: Luigi Santivetti <luigi.santivetti@xxxxxxxxxx>
> To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> To: Maxime Ripard <mripard@xxxxxxxxxx>
> To: Thomas Zimmermann <tzimmermann@xxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Simona Vetter <simona@xxxxxxxx>
> Cc: imagination@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> 
> ---
> Alessio Belle (2):
>       drm/imagination: Switch to kernel-style MMU defines and access
>       drm/imagination: Don't include MMU defines outside of MMU code
> 
>  drivers/gpu/drm/imagination/pvr_mmu.c            |  91 ++++-----
>  drivers/gpu/drm/imagination/pvr_rogue_mmu_defs.h | 239 +++++++++++------------
>  drivers/gpu/drm/imagination/pvr_vm.h             |   2 -
>  3 files changed, 151 insertions(+), 181 deletions(-)
> ---
> base-commit: 6e375de99d0c420169481fcd36064177ab55b09d
> change-id: 20260930-b4-include-mmu-defines-only-in-mmu-code-a139880f7fce
> 
> Best regards,
> --  
> Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
>