Re: [PATCH v2 1/2] dt-bindings: usb: microchip,usb251xb: add battery-charging-enable property

[Krzysztof Kozlowski]

On 03/11/2026 21:01, Jhon Wilker Rodrigues Aquino wrote:
> From: Jhon Wilker Rodrigues Aquino <jhon.aquino@xxxxxxxxxxxxxxx>

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830


> 
> Describe the battery-charging-enable property as a list of downstream ports in the USB251x device tree binding.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597


Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.


> 
> Add an example that enables charging on ports 1 and 2.
> 
> Signed-off-by: Jhon Wilker Rodrigues Aquino <jhon.aquino@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/usb251xb.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> index 0329a6aaaa928..0eb3035553c37 100644
> --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml
> @@ -230,6 +230,12 @@ properties:
>        Specifies the time it takes from the time the host initiates the
>        power-on sequence to a port until the port has adequate power.
>  
> +  battery-charging-enable:

Custom properties needs prefix, see writing bindings.

> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      Specifies the downstream ports which will have battery charging enabled.
> +      Battery charging is disabled on all ports by default.

Why wouldn't you enable charging on all ports? You have entire
description (and/or commit msg) to explain why you are doing this and
why this is exactly hardware property.

Best regards,
Krzysztof