Re: [PATCH bpf-next] selftests/bpf: Account for zero extensions in patch list expectations
From: bot+bpf-ci
Date: Tue Nov 03 2026 - 17:31:08 EST
> selftests/bpf: Account for zero extensions in patch list expectations
TL;DR: Commit message only: the Fixes: tag names a merge commit rather than
the commit that introduced patch_list_insert_in_front(), and it lacks a
preceding blank line.
> selftests/bpf: Account for zero extensions in patch list expectations
>
> patch_list_insert_in_front() checks the translated instructions around
> the call of an inlined bpf_loop() and its callback. On s390, the verifier
> adds zero extensions after the two 32-bit register writes in the loop.
> The call is therefore at instruction 25 rather than 23, and the later
> instructions checked by the test are also shifted by two. The test
> fails despite the call and jump offsets being correct.
> Use the corresponding instruction indices on s390 and RISC-V, whose
> JITs request explicit zero extensions. Keep the original expectations
> for the other enabled architectures and retain all branch offset and
> callback entry checks.
> Fixes: 57fae4059380 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf 7.4-rc1")
> Link: https://github.com/kernel-patches/bpf/actions/runs/41696128762/job/126138168160
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
The Fixes: tag names 57fae4059380, which is a merge commit. Should it name
the commit that introduced patch_list_insert_in_front() instead?
Fixes: d86e6695cb2f ("selftests/bpf: Test the tables that follow patched and removed instructions")
Also, the Fixes: line follows the body paragraph directly. Could a blank
line be added between them?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/41728315768