[PATCH v2 25/30] crypto: sa2ul - correct scatterlist DMA ownership transitions
From: Manorit Chawdhry
Date: Wed Nov 04 2026 - 00:48:52 EST
Use each scatterlist's recorded mapping direction for CPU/device
ownership transitions, including bidirectional in-place buffers.
Completion callbacks modify results after synchronizing them for CPU
access. Skip the implicit synchronization on unmap so cache maintenance
or bounce-buffer copyback cannot overwrite those CPU modifications.
Fixes: 00c9211f60db ("crypto: sa2ul - Fix DMA mapping API usage")
Signed-off-by: Manorit Chawdhry <m-chawdhry@xxxxxx>
---
drivers/crypto/sa2ul.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index e34c52de5ec4..d4c0e5b836ac 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -925,13 +925,17 @@ static int sa_3des_ecb_setkey(struct crypto_skcipher *tfm, const u8 *key,
static void sa_sync_from_device(struct sa_rx_data *rxd)
{
struct sg_table *sgt;
+ u32 dir;
- if (rxd->mapped_sg[0].dir == DMA_BIDIRECTIONAL)
+ if (rxd->mapped_sg[0].dir == DMA_BIDIRECTIONAL) {
sgt = &rxd->mapped_sg[0].sgt;
- else
+ dir = rxd->mapped_sg[0].dir;
+ } else {
sgt = &rxd->mapped_sg[1].sgt;
+ dir = rxd->mapped_sg[1].dir;
+ }
- dma_sync_sgtable_for_cpu(rxd->ddev, sgt, DMA_FROM_DEVICE);
+ dma_sync_sgtable_for_cpu(rxd->ddev, sgt, dir);
}
static void sa_free_sa_rx_data(struct sa_rx_data *rxd)
@@ -943,7 +947,7 @@ static void sa_free_sa_rx_data(struct sa_rx_data *rxd)
if (mapped_sg->mapped) {
dma_unmap_sgtable(rxd->ddev, &mapped_sg->sgt,
- mapped_sg->dir, 0);
+ mapped_sg->dir, DMA_ATTR_SKIP_CPU_SYNC);
kfree(mapped_sg->split_sg);
}
}
@@ -1110,7 +1114,7 @@ static int sa_run(struct sa_req *req)
mapped_sg->split_sg = src;
}
- dma_sync_sgtable_for_device(ddev, &mapped_sg->sgt, DMA_TO_DEVICE);
+ dma_sync_sgtable_for_device(ddev, &mapped_sg->sgt, dir_src);
if (!diff_dst) {
dst_nents = src_nents;
--
2.43.0