Re: [PATCH ath-next v2 0/2] wifi: ath12k: refactor m3/aux_uc firmware memory handling

[Madhavan Ganesan]

On 11/4/2026 12:23 PM, Baochen Qiang wrote:
> On 11/4/2026 2:30 PM, Madhavan Ganesan wrote:
> > ath12k_qmi_m3_free()/ath12k_qmi_m3_load() and
> > ath12k_qmi_aux_uc_free()/ath12k_qmi_aux_uc_load() carry near-identical
> > logic for freeing a DMA-coherent firmware memory region and loading
> > firmware into it. Factor the shared logic into common helpers.
> >
> > Patch 1 is a preparatory, no-functional-change rename of
> > struct m3_mem_region to struct ath12k_fw_mem_region, since the type
> > is also used for the aux_uc region and the old name no longer
> > reflects its purpose.
> >
> > Patch 2 refactors the shared free/load logic into
> > ath12k_qmi_free_mem_region() and ath12k_qmi_fw_mem_load(), and
> > rewires the m3 and aux_uc wrappers to use them.
> >
> > ---
> > Changes in v2:
> > - Addressed the review comments.
>
> this is not enough: you need to clearly state what are changed in each patch.

Acked.
From next revision, I will clearly mention what I changed in updated 
patch set.

> And I already gave my Reviewed-by: in v1 review, any reason why you didn't carry it in
> this post? I don't see any major difference between this and the previous revision.

Based on Jeff's review comments, I have cleared the paddr and reorder 
the function definition. So, I thought I cannot retain your Reviewed-by 
tag. Please let me know if I need to re-spin with Reviewed-by tag.