Re: [PATCH] media: exynos4-is: Free control handler if fimc-lite subdev init fails
From: Krzysztof Kozlowski
Date: Wed Nov 04 2026 - 02:22:44 EST
On 03/11/2026 10:46, Wentao Liang wrote:
> fimc_lite_create_capture_subdev() initializes fimc->ctrl_handler and adds
> a control to it. If the control cannot be created, handler->error is set
> and the function returns after cleaning up the media entity only. The
> control handler still owns the memory allocated for its buckets and for
> any control created before the failure, and fimc_lite_probe() does not
> call fimc_lite_unregister_capture_subdev() on this error, so that memory
> is leaked.
>
> Free the control handler before returning the error.
>
> Fixes: 4af813108b88 ("[media] s5p-fimc: Add support for Exynos4x12 FIMC-LITE")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
This is another posting of bot ignoring feedback and probably
introducing vilnerabilities hidden in big spam posting.
Best regards,
Krzysztof