Re: [PATCH] iio: adc: ad4134: Fix duplicate data_read mux state request
From: Joshua Crofts
Date: Wed Nov 04 2026 - 03:13:16 EST
On Wed, 4 Nov 2026 12:47:19 +0800
Chen Ni <nichen@xxxxxxxxxxx> wrote:
> devm_mux_state_get(dev, "data_read") is called twice in a row. The
> second call's result is stored directly into
> st->mux_st[AD4134_DOUT0_INPUT] without error checking, and then
> immediately overwritten by the first call's result.
>
> Remove the duplicate call and check the return value before saving the
> state.
>
> Fixes: f12ecb3e147b ("iio: adc: ad4134: Support SPI 4-wire mode")
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
Reviewed-by: Joshua Crofts <crofts@xxxxxxxxxx>
--
Kind regards,
Joshua Crofts