Re: [PATCH 23/27] usb: dwc3: Configure RK3572 PIPE port before discovery

[Cunhao Lu]

Hi,

> This can just be:
> if (device_property_match_string(dev, "phy-names", "usb3-phy") >= 0 &&
>     (speed == USB_SPEED_UNKNOWN || speed >= USB_SPEED_SUPER))

Agreed. This glue-side check will be removed with the helper when the
configuration moves to the PHY drivers.

> This looks like something that can be done in the phy driver. The other
> Rockchip platforms such as RK3588 do this in the phy right? Why it must
> be here?

You are right. I checked the RK3572 hardware capabilities and tested a
PHY-based implementation on the OK3572-C. Both controllers report DRD
capability, so DWC3 uses one USB2 and one USB3 port rather than taking the
host-only port-discovery path. On USB1, USB3 PHY initialization is still
called with the PIPE port disabled. My original reason for placing this
before DWC3 core probe was incorrect.

I will fix this issue in v2.

Best regards,
Cunhao Lu