Re: [PATCH] usb: host: ehci-xilinx-of: remove the driver

[Michal Simek]

On 11/3/26 19:17, Radhey Shyam Pandey wrote:
> The Xilinx XPS USB host controller is legacy soft IP for PPC405 and
> MicroBlaze FPGA designs.
>
> This IP core relies on Xilinx Platform Studio (XPS) and the ISE Design
> Suite, both of which were discontinued by Xilinx years ago. Furthermore,
> modern AMD toolchains (Vivado Design Suite and Vitis) provide no support
> for the legacy PLB (Processor Local Bus) architecture used by this core.
> As a result, no new hardware designs can be built using this IP.
>
> Nothing in the upstream tree carries its "xlnx,xps-usb-host-1.00.a"
> compatible string, no defconfig enables CONFIG_XPS_USB_HCD_XILINX, and
> the compatible was never documented as a binding.
>
> It is also one of the few remaining users of the deprecated glue model
> where the .c file is #included into ehci-hcd.c rather than built as its
> own object.
>
> Given the complete obsolescence of the supporting hardware development
> tools and the lack of upstream users, remove the dead driver.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
> ---
>   drivers/usb/host/Kconfig          |  11 --
>   drivers/usb/host/ehci-hcd.c       |   7 -
>   drivers/usb/host/ehci-xilinx-of.c | 229 ------------------------------
>   scripts/dtc/dt_to_config          |   8 +-
>   4 files changed, 2 insertions(+), 253 deletions(-)
>   delete mode 100644 drivers/usb/host/ehci-xilinx-of.c
We discussed this in context of Documentation/devicetree/bindings/xilinx.txt but 
there should be one more patch which removes that one documented property from 
xilinx.txt here.

It means please also send another patch which removes this part. I would suggest 
that this should be series of 2 patches. Where one removes driver itself and 
second this paragraph from xilinx.txt.

This patch is file that's why feel free to add

Reviewed-by: Michal Simek <michal.simek@xxxxxxx>

diff --git a/Documentation/devicetree/bindings/xilinx.txt 
b/Documentation/devicetree/bindings/xilinx.txt
index a1a2cde7b7d8..5049af6ff4cf 100644
--- a/Documentation/devicetree/bindings/xilinx.txt
+++ b/Documentation/devicetree/bindings/xilinx.txt
@@ -29,15 +29,3 @@
                - compatible : should contain "xlnx,xps-hwicap-1.00.a" or
                                "xlnx,opb-hwicap-1.00.b".

-      vii) Xilinx USB Host controller
-
-      The Xilinx USB host controller is EHCI compatible but with a different
-      base address for the EHCI registers, and it is always a big-endian
-      USB Host controller. The hardware can be configured as high speed only,
-      or high speed/full speed hybrid.
-
-      Required properties:
-      - xlnx,support-usb-fs: A value 0 means the core is built as high speed
-                             only. A value 1 means the core also supports
-                             full speed devices.
-

Thanks,
Michal