Re: [PATCH 2/5] arm64: dts: qcom: sc8180x: Add Microsoft Surface Pro X

[Konrad Dybcio]

On 11/4/26 8:04 AM, Val Packett wrote:
> From: Maximilian Luz <luzmaximilian@xxxxxxxxx>
> 
> Introduce a device tree for the Surface Pro X tablet in all 3 variants
> (SQ1 with cellular, SQ1 Wi-Fi only, SQ2 with cellular).
> 
> Currently working:
> 
> * Display, backlight (eDP panel)
> * USB 2.0
> * Wi-Fi and Bluetooth (WCN3998)
> * NVMe on PCIe2
> * Embedded controller (Surface SAM over UART)
> * All remoteprocs (ADSP, CDSP, MPSS, SLPI)
> * Volume and power buttons

[...]

This needs some sorting etc., but let's tackle the bigger prob first


> +&mdss_edp {
> +	pinctrl-0 = <&edp_hpd_active>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +
> +	aux-bus {
> +		panel {
> +			compatible = "edp-panel";
> +			enable-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>;
> +			no-hpd;

Is there really no HPD? The pinctrl above suggests otherwise

[...]

> +&pcie2 {
> +	// XXX: pcie1 and pcie2 are multi'd together, for now use just one
> +	num-lanes = <2>;

We should be using the new phy-qcom-qmp-pcie-multiphy.c driver I think,
I'll try chasing down the right magic values

> +
> +	pinctrl-0 = <&pcie1_default_state>;
> +	pinctrl-names = "default";
> +
> +	// HACK: Remove "global" interrupt

Why?

Konrad