Re: [PATCH 2/2] gpio: Add Siflower GPIO controller driver

From: Joseph Telaak

Date: Wed Nov 04 2026 - 03:42:20 EST


> Same comment as for the DT binding patch.

Will do.

> More common pattern is to retrieve the address of priv with
> gpiochip_get_data(). You already pass that address to
> devm_gpiochip_add_data().

Thanks for the review. v2 will use gpiochip_get_data(), drop both else
branches and add the blank line after the header comment.