Re: [PATCH v6 5/5] arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators

[Krzysztof Kozlowski]

On Wed, Nov 04, 2026 at 11:26:48AM +0800, Qianhui Xu wrote:
> The camera devices of the Lenovo Legion Y700 Gen4 are powered by a
> WL2868C camera PMIC on i2c10: LDO1 feeds the rear sensor DVDD, LDO2 the
> front sensor DVDD, LDO3 the front sensor AVDD, LDO4 the rear sensor
> AVDD, LDO5 the VCM VDD, LDO7 the DOVDD of both sensors and the VCM
> VDDIO, all at fixed voltages including the offsets programmed by the
> stock firmware. LDO6 is not wired out on this board.
> 
> i2c10 is a GENI I2C controller inside the qupv3_2 wrapper, so both
> qupv3_2 and its gpi_dma2 parent are enabled alongside, otherwise i2c10
> never populates and the regulators would never register.
> 
> The VSYS input of the PMIC is the always-on system rail of the tablet
> and is described as a fixed regulator. The VIN12, VIN34, VIN5 and VIN7
> inputs are fed by SPMI PMIC rails that are not described yet, so they
> are left out and follow with the board series that adds the PMICs.
> 
> The consumers of these regulators (the rear sensor and its VCM on
> cci0) are not described here: the CCI controllers are being added by
> Hangxiang Ma's SM8750 series, and the sensor nodes follow with the
> camera series that depends on it.
> 
> Signed-off-by: Qianhui Xu <xiaqinghuan@xxxxxxxxxxxxxxxx>
> ---
>  .../boot/dts/qcom/sm8750-lenovo-elden.dts     | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)

I do not understand why this is a separate patch. You add new hardware,
so the commit is "add new hardware". One logical action, one commit.

Best regards,
Krzysztof