Re: [PATCH v4 01/22] ASoC: dt-bindings: cs42l84: Allow referenced dai-common properties
From: Krzysztof Kozlowski
Date: Wed Nov 04 2026 - 05:48:38 EST
On Tue, Nov 03, 2026 at 05:39:49PM +1000, James Calligeros wrote:
> Some consumers may wish to prepend the codec's name with a known value
> to identify a specific codec among many and set #sound-dai-cells. Allow
> this by allowing referenced properties from dai-common.yaml.
>
> Signed-off-by: James Calligeros <jcalligeros99@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> index 94062c1d9d45..66cae8b7db5d 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> @@ -9,6 +9,9 @@ title: Cirrus Logic CS42L84 audio CODEC
> maintainers:
> - Martin Povišer <povik+lin@xxxxxxxxxxx>
>
> +allOf:
> + - $ref: dai-common.yaml#
> +
> description: |
> The CS42L84 is a headphone jack codec made by Cirrus Logic and embedded
> in personal computers sold by Apple. It was first seen in 2021 Macbook
> @@ -29,14 +32,11 @@ properties:
> interrupts:
> maxItems: 1
>
> - '#sound-dai-cells':
> - const: 0
This should not be removed. Why cells of 1 would be correct? If so,
explain in commit msg.
Best regards,
Krzysztof