Re: [PATCH 11/11] pinctrl: scmi: select the GPIO function on GPIO requests

From: Andy Shevchenko

Date: Wed Nov 04 2026 - 05:55:44 EST


On Wed, Nov 04, 2026 at 10:38:11AM +0100, Clément Le Goffic wrote:
> On 11/3/26 12:41 PM, Andy Shevchenko wrote:
> > On Fri, Oct 30, 2026 at 04:58:42PM +0100, Clément Le Goffic wrote:

...

> >> + int nr_functions, func, ret;
> >> +
> >> + nr_functions = pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE);
> >
> > Is nr_functions signed for a purpose? Can it hold an error code?
>
> No indeed, will fix in v2.

> >> + for (func = 0; func < nr_functions; func++) {
> >
> > for (int func = 0; func < nr_functions; func++) {

With the above in mind, the type of func has to be adjusted accordingly.

--
With Best Regards,
Andy Shevchenko