Re: [PATCH] ASoC: pcm3168a: don't request the reset GPIO as non-exclusive
From: Cezary Rojewski
Date: Wed Nov 04 2026 - 06:10:55 EST
On 11/4/2026 9:06 AM, Bartosz Golaszewski wrote:
> On Wed, Nov 04, 2026 at 12:03:55AM +0000, Mark Brown wrote:
>>> The GPIOD_FLAGS_BIT_NONEXCLUSIVE flag is deprecated and users should
>>> rely on the GPIO shared proxy. All users of this codec driver are ARM64
>>> and this architecture now enables automatically shared GPIOs for
>>> everyone. The driver now longer has to care about the sharing so drop
>>> the flag.
>>
>> sound/soc/intel/avs/boards/pcm3168a.c would beg to differ about this
>> being arm64 only, though that only has one CODEC and shouldn't share the
>> GPIO so it should be fine.
>>
Thank you, Mark, for mentioning this. Indeed, the x86 user (avs-driver)
does not utilize the GPIO but does utilize pcm3168a codec nonetheless.
> Right. Do you want me to resend with commit message amended?
While at it, two nitpicks:
ASoC: pcm3168a: -> ASoC: codecs: pcm3168a:
don't -> do not
(the last one simply makes the greps easier, and is more of a preference
thing).